| ... | @@ -2,22 +2,22 @@ |
... | @@ -2,22 +2,22 @@ |
|
|
我从[这些角度](https://github.com/google/eng-practices/blob/master/review/reviewer/looking-for.md)来做代码审核。
|
|
我从[这些角度](https://github.com/google/eng-practices/blob/master/review/reviewer/looking-for.md)来做代码审核。
|
|
|
|
|
|
|
|
## 设计
|
|
## 设计
|
|
|
- [项目地址](http://tech.pingansec.com/granite/project-judicature/-/tree/dev_court_notice/scrapy_spiders/judicature_spiders)
|
|
- [项目地址](http://192.168.109.110/granite/project-judicature/-/tree/dev_court_notice/scrapy_spiders/judicature_spiders)
|
|
|
- 文件夹目录结构清晰
|
|
- 文件夹目录结构清晰
|
|
|
- 但是两个项目混在一起
|
|
- 但是两个项目混在一起
|
|
|
- pyreverse对类的组合支持不好
|
|
- pyreverse对类的组合支持不好
|
|
|
|
|
|
|
|
## 复杂性
|
|
## 复杂性
|
|
|
- [field_map.py](http://tech.pingansec.com/granite/project-judicature/-/blob/dev_court_notice/scrapy_spiders/judicature_spiders/utils/wenshu/field_map.py)
|
|
- [field_map.py](http://192.168.109.110/granite/project-judicature/-/blob/dev_court_notice/scrapy_spiders/judicature_spiders/utils/wenshu/field_map.py)
|
|
|
- 对IDE不友好
|
|
- 对IDE不友好
|
|
|
- class
|
|
- class
|
|
|
- [namedtuple](https://docs.python.org/zh-cn/3.7/library/collections.html#collections.namedtuple)
|
|
- [namedtuple](https://docs.python.org/zh-cn/3.7/library/collections.html#collections.namedtuple)
|
|
|
- [dataclass](https://docs.python.org/zh-cn/3.7/library/dataclasses.html) 推荐
|
|
- [dataclass](https://docs.python.org/zh-cn/3.7/library/dataclasses.html) 推荐
|
|
|
- [util.py](http://tech.pingansec.com/granite/project-judicature/-/blob/dev_court_notice/scrapy_spiders/judicature_spiders/utils/wenshu/util.py)
|
|
- [util.py](http://192.168.109.110/granite/project-judicature/-/blob/dev_court_notice/scrapy_spiders/judicature_spiders/utils/wenshu/util.py)
|
|
|
- ConditionDynamicSingleLink
|
|
- ConditionDynamicSingleLink
|
|
|
- Compress
|
|
- Compress
|
|
|
- [wenshu.py](http://tech.pingansec.com/granite/project-judicature/-/blob/dev_court_notice/scrapy_spiders/judicature_spiders/spiders/wenshu.py#L77)
|
|
- [wenshu.py](http://192.168.109.110/granite/project-judicature/-/blob/dev_court_notice/scrapy_spiders/judicature_spiders/spiders/wenshu.py#L77)
|
|
|
- [cookie_manager.py](http://tech.pingansec.com/granite/project-judicature/-/blob/dev_court_notice/scrapy_spiders/judicature_spiders/utils/wenshu/cookie_manager.py)
|
|
- [cookie_manager.py](http://192.168.109.110/granite/project-judicature/-/blob/dev_court_notice/scrapy_spiders/judicature_spiders/utils/wenshu/cookie_manager.py)
|
|
|
- 异步
|
|
- 异步
|
|
|
- 最大并发请求数限制?
|
|
- 最大并发请求数限制?
|
|
|
- CookieManager线程安全?
|
|
- CookieManager线程安全?
|
| ... | | ... | |
