Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
K
kb
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • granite
  • kb
  • Wiki
    • Code review
  • ic_info_change

ic_info_change · Changes

Page history
add: review修改意见的文档更新 authored Nov 25, 2021 by 袁波's avatar 袁波
Show whitespace changes
Inline Side-by-side
Showing with 7 additions and 7 deletions
+7 -7
  • code-review/ic_info_change.md code-review/ic_info_change.md +7 -7
  • No files found.
code-review/ic_info_change.md
View page @ 3fb588a8
......@@ -17,13 +17,13 @@
### 整体感知
```buildoutcfg
1. 代码干净、简洁,好评
2. 文档不全,不适合新手自主上手
2. 文档不全,不适合新手自主上手,一脸懵逼
```
### 值得学习的地方
```buildoutcfg
1. 代码干净、简洁,没看到多余乱七八糟的代码
2. 文档不全,不适合新手自主上手
1.
```
......@@ -50,7 +50,7 @@
5、命名
a、从类名来看不知道这个类的作用
a、ic_pc.py 42行 format_task_params 全是task_params
b、get_one_goods函数的作用是解析json 命名不够直抒胸意,可改为parse_goods
......@@ -69,9 +69,9 @@
```
### 规范性
```buildoutcfg
1. 缺少项目文档readme.md
2. pip freeze > requirements.txt 将环境导出来,新环境可以pip install -r requirements.txt
```
建议: <1>添加readme.md,整体说明爬虫目的,快速启动以及部署等。
<2>pip freeze > requirements.txt 导出当前环境依赖包
```
---
......
Clone repository
  • README
  • basic_guidelines
  • basic_guidelines
    • basic_guidelines
    • dev_guide
    • project_build
    • 开发流程
  • best_practice
  • best_practice
    • AlterTable
    • RDS
    • azkaban
    • create_table
    • design
    • elasticsearch
    • elasticsearch
      • ES运维
    • logstash
View All Pages