Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
K
kb
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • granite
  • kb
  • Wiki
    • Code review
  • ic_info_change

ic_info_change · Changes

Page history
update: review authored Nov 25, 2021 by 王鹏举's avatar 王鹏举
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 0 deletions
+4 -0
  • code-review/ic_info_change.md code-review/ic_info_change.md +4 -0
  • No files found.
code-review/ic_info_change.md
View page @ de2a711c
......@@ -60,6 +60,8 @@ http://tech.pingansec.com/granite/project-ic-spiders/-/blob/dev_ic_pc_py3/app_ic
a、index.py文件 yield from、return、yield
b、太多if else 判断就显得代码特别乱, 是否可以抽取出方法处理。
c、detail_url.py parse_response方法, 2个yield,1个return
d、Task和Result中循环引用的影响
e、并发控制策略的有效性
4. 不足
......@@ -75,6 +77,8 @@ http://tech.pingansec.com/granite/project-ic-spiders/-/blob/dev_ic_pc_py3/app_ic
f、index.py parse_response 顺序不太合理
g、无README.md
```
......
Clone repository
  • README
  • basic_guidelines
  • basic_guidelines
    • basic_guidelines
    • dev_guide
    • project_build
    • 开发流程
  • best_practice
  • best_practice
    • AlterTable
    • RDS
    • azkaban
    • create_table
    • design
    • elasticsearch
    • elasticsearch
      • ES运维
    • logstash
View All Pages