Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
K
kb
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • granite
  • kb
  • Wiki
    • Code review
  • procedures

procedures · Changes

Page history
Create code review/procedures authored Nov 04, 2021 by 李林坳's avatar 李林坳
Hide whitespace changes
Inline Side-by-side
Showing with 28 additions and 0 deletions
+28 -0
  • code-review/procedures.md code-review/procedures.md +28 -0
  • No files found.
code-review/procedures.md 0 → 100644
View page @ 07a10736
## 评审目标
1. 实现方案的正确性
2. 代码的会味道
3. 规范性
### 实现方案的正确性
* 被评审人需先整体描述需要解决的问题、解决流程
### 代码的会味道
1. 无效代码
2. 重复代码
3. 异常处理
4. 必要注释
### 规范性
1. 缺少项目文档 (app_environ_protection_grade/readme.md)
2. data_pump配置文件,缺少流程必要注释说明, 缺少profile (方便随时测试、复现)
---
### 改进落实
时间:
负责人:
必须纠正:
\ No newline at end of file
Clone repository
  • README
  • basic_guidelines
  • basic_guidelines
    • basic_guidelines
    • dev_guide
    • project_build
    • 开发流程
  • best_practice
  • best_practice
    • AlterTable
    • RDS
    • azkaban
    • create_table
    • design
    • elasticsearch
    • elasticsearch
      • ES运维
    • logstash
View All Pages