|
|
|
## 评审目标
|
|
|
|
|
|
|
|
```buildoutcfg
|
|
|
|
1. 实现方案的正确性
|
|
|
|
2. 代码的坏味道
|
|
|
|
3. 规范性
|
|
|
|
```
|
|
|
|
|
|
|
|
### 评审日期
|
|
|
|
|
|
|
|
```
|
|
|
|
2022-04-21
|
|
|
|
```
|
|
|
|
|
|
|
|
### 评审人
|
|
|
|
|
|
|
|
```
|
|
|
|
蒋家升,杨龙斌
|
|
|
|
```
|
|
|
|
|
|
|
|
### 被评审人
|
|
|
|
|
|
|
|
```
|
|
|
|
刘东洋
|
|
|
|
```
|
|
|
|
|
|
|
|
### 参考链接
|
|
|
|
|
|
|
|
- [代码入口](http://tech.pingansec.com/granite/project-metrics)
|
|
|
|
|
|
|
|
### 流程
|
|
|
|
|
|
|
|
```buildoutcfg
|
|
|
|
1. 被评审人需先整体描述需要解决的问题、解决流程 (被评审人讲解过程中,评审人可以记录问题,不要打断被评审者的思路)
|
|
|
|
2. 被评审人讲完,评审人和与会人员可以提问题
|
|
|
|
3. 评审人进行评审 (被评审者或者与会人员记录评审待改进的内容,有时并不是只针对被评审者,而是所有编码者)
|
|
|
|
4. 评审完成之后,落实待修改项,主要是缺陷和规范性
|
|
|
|
```
|
|
|
|
|
|
|
|
### 描述整体业务逻辑
|
|
|
|
```buildoutcfg
|
|
|
|
|
|
|
|
```
|
|
|
|
|
|
|
|
### 建议
|
|
|
|
|
|
|
|
[jjs_advise](http://tech.pingansec.com/granite/project-metrics/-/blob/review/review.md)
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
### 改进落实
|
|
|
|
|
|
|
|
```buildoutcfg
|
|
|
|
时间:
|
|
|
|
|
|
|
|
改进人:
|
|
|
|
|
|
|
|
监督人:
|
|
|
|
``` |