Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
K
kb
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • granite
  • kb
  • Wiki
    • Code review
  • proj_metrics

proj_metrics · Changes

Page history
add: review: project-metrics; authored Apr 21, 2022 by 蒋家升's avatar 蒋家升
Show whitespace changes
Inline Side-by-side
Showing with 59 additions and 0 deletions
+59 -0
  • code-review/proj_metrics.md code-review/proj_metrics.md +59 -0
  • No files found.
code-review/proj_metrics.md 0 → 100644
View page @ 342fec1c
## 评审目标
```buildoutcfg
1. 实现方案的正确性
2. 代码的坏味道
3. 规范性
```
### 评审日期
```
2022-04-21
```
### 评审人
```
蒋家升,杨龙斌
```
### 被评审人
```
刘东洋
```
### 参考链接
- [代码入口](http://tech.pingansec.com/granite/project-metrics)
### 流程
```buildoutcfg
1. 被评审人需先整体描述需要解决的问题、解决流程 (被评审人讲解过程中,评审人可以记录问题,不要打断被评审者的思路)
2. 被评审人讲完,评审人和与会人员可以提问题
3. 评审人进行评审 (被评审者或者与会人员记录评审待改进的内容,有时并不是只针对被评审者,而是所有编码者)
4. 评审完成之后,落实待修改项,主要是缺陷和规范性
```
### 描述整体业务逻辑
```buildoutcfg
```
### 建议
[jjs_advise](http://tech.pingansec.com/granite/project-metrics/-/blob/review/review.md)
---
### 改进落实
```buildoutcfg
时间:
改进人:
监督人:
```
Clone repository
  • README
  • basic_guidelines
  • basic_guidelines
    • basic_guidelines
    • dev_guide
    • project_build
    • 开发流程
  • best_practice
  • best_practice
    • AlterTable
    • RDS
    • azkaban
    • create_table
    • design
    • elasticsearch
    • elasticsearch
      • ES运维
    • logstash
View All Pages